PPT Slide

Writing Methods--Flawed Example

public char letterGrade (int iGrade) {

util.ASSERT(iGrade >= 0 && iGrade <=100,

“iGrade param has invalid value.”);

if (iGrade >= 90)

return (“A”);

if (iGrade >= 80 || iGrade < 90)

return (“B”);

if (iGrade >= 70 || iGrade < 80)

return (“C”);

if (iGrade >= 60 || iGrade < 70)

return (“D”);

if (iGrade <= 60)

return (“F”);

} // of letterGrade

What’s wrongwith this?

--Error: returns a String, not a char!

--Style: multiple returns are to be avoided, if possible

--Style: use if/else chain to avoid unintended execution of code